Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds options for cpp linting to help section of Windows build script #11992

Closed
wants to merge 1 commit into from

Conversation

brennemo
Copy link
Contributor

Adds options for cpp linting to help section of Windows build script

Fixes: #11971

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 22, 2017
@gibfahn
Copy link
Member

gibfahn commented Mar 22, 2017

cc/ @refack

@gibfahn gibfahn added the windows Issues and PRs related to the Windows platform. label Mar 22, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Mar 22, 2017

@brennemo Thank you for the contribution. A nit: it seems the commit title exceed required 50 characters and lacks subsystem prefix (@gibfahn, should it be doc or build?). Could you amend it, using also the mentioned lowercase and imperative verb?

@refack
Copy link
Contributor

refack commented Mar 22, 2017

LGTM pending @vsemozhetbyt's comment
(not being condescending, but it should be simple then git push -f)

@gibfahn
Copy link
Member

gibfahn commented Mar 22, 2017

Good point @vsemozhetbyt , @brennemo maybe something like this for the commit message:

build: add lint option to vcbuild.bat help

Also your name in git is currently:

Morgan <brennemo@oregonstate.edu>

People usually choose to use their full names for commits. To set your name globally you can do:

git config --global user.name "Morgan Brenner"

To change the author and commit message you can do:

git commit --amend --author="Morgan Brenner <brennemo@oregonstate.edu>"
# Edit commit message when it pops up
git push --force-with-lease

@brennemo
Copy link
Contributor Author

Sure, I amended the author to add my last name and updated the commit message.

@vsemozhetbyt
Copy link
Contributor

jasnell pushed a commit that referenced this pull request Mar 24, 2017
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 24, 2017

Landed in a8a042a

@jasnell jasnell closed this Mar 24, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
@MylesBorins
Copy link
Contributor

should this be backported?

@refack
Copy link
Contributor

refack commented May 15, 2017

I'm +0.1 (it's a tiny documentation change, so little gain little risk)
It's just a "docs bug fix" for #11856

@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

@refack would you mind backporting this and 379eec3 to v6.x-staging?

guide

@refack
Copy link
Contributor

refack commented Jun 17, 2017

@refack would you mind backporting this and 379eec3 to v6.x-staging?

Ack.
Re guide: #13749

refack pushed a commit to refack/node that referenced this pull request Aug 22, 2017
PR-URL: nodejs#11992
Fixes: nodejs#11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
180bec1
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new lint option on windows is missing documentation
9 participants