node: warn if cwd is inaccessible during bootstrap #12022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
Fishrock123
force-pushed
the
warn-on-inaccesible-cwd
branch
from
cee2c9b
to
f381a70
Compare
|
|
Ah ok, will write a test in a bit. |
cjihrig
requested changes
Mar 24, 2017
lib/internal/bootstrap_node.js
Outdated
| @@ -374,6 +374,9 @@ | |||
| threw = false; | |||
| } finally { | |||
| if (threw) { | |||
| process.emitWarning('The Current Working Directory was inaccessible.\n', | |||
There was a problem hiding this comment.
Can you lowercase Current Working Directory.
lib/internal/bootstrap_node.js
Outdated
| @@ -374,6 +374,9 @@ | |||
| threw = false; | |||
| } finally { | |||
| if (threw) { | |||
| process.emitWarning('The Current Working Directory was inaccessible.\n', | |||
| 'Falling back to the executable\'s directory...', | |||
There was a problem hiding this comment.
Can you drop the last two dots.
jasnell
requested changes
Mar 24, 2017
lib/internal/bootstrap_node.js
Outdated
| @@ -374,6 +374,9 @@ | |||
| threw = false; | |||
| } finally { | |||
| if (threw) { | |||
| process.emitWarning('The Current Working Directory was inaccessible.\n', | |||
There was a problem hiding this comment.
comma at the end of this line... did you mean to put a + here instead?
|
ok, looks like there's more to it than this. Something loads |
|
I think the solution there would probably be to overload |
Fishrock123
force-pushed
the
warn-on-inaccesible-cwd
branch
from
f381a70
to
f14c96f
Compare
|
The cwd being removed is only supported for evaluating code. Not running "normally." I added a known issue test in #12343. We could add a better message for other scenarios, or set the cwd like we do for eval script. |
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Apr 18, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Refs: nodejs#12022 PR-URL: nodejs#12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Ping @Fishrock123 |
|
Closing this due to a long inactivity. Please feel free to reopen if you want to follow up on this @Fishrock123 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 29, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Refs: nodejs#12022 PR-URL: nodejs#12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Backport-PR-URL: #15479 Refs: #12022 PR-URL: #12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Backport-PR-URL: #15479 Refs: #12022 PR-URL: #12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
bootstrap
This was added/fixed in 2c6f79c and seems like it could be quite confusing, so... maybe we should warn? ¯\_(ツ)_/¯
I don't really know how to trigger this though, so no test... for now?
cc @bnoordhuis, maybe this isn't a good idea, idk.