deps: backport 8dde6ac from upstream V8 #12060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9c9e2d7 changed the name of TypeFeedbackVector to FeedbackVector but that commit did not update gdbinit. This applies the changed to gdbinit from upstream V8. Original commit message: [gdbinit] Rename TypeFeedback* to Feedback*. BUG= Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b Reviewed-on: https://chromium-review.googlesource.com/442444 Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#43185}
nodejs-github-bot
added
the
v8 engine
bnoordhuis
approved these changes
Mar 27, 2017
targos
approved these changes
Mar 27, 2017
cjihrig
approved these changes
Mar 27, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Mar 29, 2017
Commit 9c9e2d7 changed the name of TypeFeedbackVector to FeedbackVector but that commit did not update gdbinit. This applies the changed to gdbinit from upstream V8. Original commit message: [gdbinit] Rename TypeFeedback* to Feedback*. BUG= Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b Reviewed-on: https://chromium-review.googlesource.com/442444 Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#43185} PR-URL: nodejs#12060 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 678480e |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
Commit 9c9e2d7 changed the name of TypeFeedbackVector to FeedbackVector but that commit did not update gdbinit. This applies the changed to gdbinit from upstream V8. Original commit message: [gdbinit] Rename TypeFeedback* to Feedback*. BUG= Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b Reviewed-on: https://chromium-review.googlesource.com/442444 Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#43185} PR-URL: nodejs#12060 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
I assumed this does not need to land on v6.x Suprised that it landed on 7.x, as it would appear to only be relevant for V8 5.7 /cc @nodejs/v8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9c9e2d7 changed the name of TypeFeedbackVector to
FeedbackVector but that commit did not update gdbinit. This applies the
changed to gdbinit from upstream V8.
Original commit message:
[gdbinit] Rename TypeFeedback* to Feedback*.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps