Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage of internal/socket_list #12066

Closed
wants to merge 1 commit into from
Closed

test: increase coverage of internal/socket_list #12066

wants to merge 1 commit into from

Conversation

DavidCai1111
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 27, 2017
@Fishrock123
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7056/

jasnell
jasnell approved these changes Mar 27, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI comes back good.

@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Mar 27, 2017
@jasnell
Copy link
Member

jasnell commented Mar 30, 2017

CI is a bit challenged, it seems unrelated but just in case: https://ci.nodejs.org/job/node-test-pull-request/7101/

@jasnell
Copy link
Member

jasnell commented Apr 4, 2017

Yet another CI run : https://ci.nodejs.org/job/node-test-pull-request/7203/

jasnell pushed a commit that referenced this pull request Apr 4, 2017
@DavidCai1111 @jasnell
test: increase coverage of internal/socket_list
610ac7d 
PR-URL: #12066
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 4, 2017

Landed in 610ac7d

@jasnell jasnell closed this Apr 4, 2017
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DavidCai1111 @Fishrock123 @jasnell @gibfahn @cjihrig @mscdex @italoacasas @nodejs-github-bot