Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: add space between error name and code #12099

Closed
wants to merge 1 commit into from
Closed

errors: add space between error name and code #12099

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 28, 2017

Error[CODE] becomes Error [CODE]

Depends on: #11220

/cc @Trott @evanlucas

(I'm not sure how to classify this on the semver scale since we have not actually used it yet)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

@jasnell
errors: add space between error name and code
99b4d18 
`Error[CODE]` becomes `Error [CODE]`
@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Mar 28, 2017
@jasnell jasnell requested review from evanlucas and Trott March 28, 2017 19:43
Trott
Trott approved these changes Mar 28, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gibfahn
Copy link
Member

gibfahn commented Mar 28, 2017

(I'm not sure how to classify this on the semver scale since we have not actually used it yet)

seems like a semver-patch then.

@gibfahn gibfahn mentioned this pull request Mar 28, 2017
Closed
4 tasks
evanlucas
evanlucas approved these changes Mar 29, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is better. Thanks!

@addaleax addaleax added this to the 8.0.0 milestone Mar 31, 2017
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7144/

jasnell added a commit that referenced this pull request Apr 3, 2017
@jasnell
errors: add space between error name and code
7b4a72d 
`Error[CODE]` becomes `Error [CODE]`

PR-URL: #12099
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@jasnell
Copy link
Member Author

jasnell commented Apr 3, 2017

Landed in 7b4a72d

@jasnell jasnell closed this Apr 3, 2017
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @gibfahn @addaleax @evanlucas @Trott @lpinca @nodejs-github-bot