Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.8.2 proposal #12129

Merged
merged 4 commits into from
Apr 4, 2017
Merged

v4.8.2 proposal #12129

merged 4 commits into from
Apr 4, 2017

Conversation

MylesBorins
Copy link
Contributor

2017-04-04, Version 4.8.2 'Argon' (LTS), @MylesBorins

This is a special LTS to fix a memory leak that was introduced in 4.8.1.

It also includes an upgrade to zlib 1.2.11 to fix a number of low severity CVEs
that were present in zlib 1.2.8.

Notable Changes

  • crypto:
    • fix memory leak if certificate is revoked (Tom Atkinson) #12089
  • deps:
    • upgrade zlib to 1.2.11 (Sam Roberts) #10980

Commits

  • [9d7fba4de2] - crypto: fix memory leak if certificate is revoked (Tom Atkinson) #12089
  • [253980ff38] - deps: fix CLEAR_HASH macro to be usable as a single statement (Sam Roberts) #11616
  • [2e52a2699b] - deps: upgrade zlib to 1.2.11 (Sam Roberts) #10980

Tom Atkinson and others added 3 commits March 29, 2017 14:28
The additional validity checks applied to StartCom and WoSign
certificates failed to free memory before returning.

Refs: #9469
Fixes: #12033
PR-URL: #12089
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #10980
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Apply unreleased (as of zlib v1.2.11) patch from upstream:
- madler/zlib@38e8ce3

Original commit message:
  Fix CLEAR_HASH macro to be usable as a single statement.

  As it is used in deflateParams().

PR-URL: #11616
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v4.x zlib Issues and PRs related to the zlib subsystem. labels Mar 29, 2017
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Mar 29, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7095/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/679/

rc.1: https://nodejs.org/download/rc/v4.8.2-rc.1/

edit: ci failures appear infra related. CITGM failures are all either timeouts or issues with phantomJS

@mscdex mscdex removed the zlib Issues and PRs related to the zlib subsystem. label Mar 29, 2017
@richardlau
Copy link
Member

Should we draw attention to Argon entering Maintenance?

This is a maintenance release to fix a memory leak that was
introduced in 4.8.1.

It also includes an upgrade to zlib 1.2.11 to fix a number of low
severity CVEs that were present in zlib 1.2.8.

http://seclists.org/oss-sec/2016/q4/602

Notable changes:

* crypto:
  - fix memory leak if certificate is revoked (Tom Atkinson)
    #12089
* deps:
  - upgrade zlib to 1.2.11 (Sam Roberts)
    #10980
@MylesBorins MylesBorins merged commit ea2ceac into v4.x Apr 4, 2017
MylesBorins added a commit that referenced this pull request Apr 4, 2017
@gibfahn gibfahn deleted the v4.8.2-proposal branch April 4, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants