Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: avoid passing kill empty input in Makefile #12158

Merged
merged 1 commit into from
Apr 4, 2017
Merged

build: avoid passing kill empty input in Makefile #12158

merged 1 commit into from
Apr 4, 2017

Commits on Apr 4, 2017

  1. build: avoid passing kill empty input in Makefile 

    Using `xargs -r` on some platforms and `xargs` on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

PR-URL: nodejs#12158
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @gibfahn
    gibfahn committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    d19809a View commit details
    Browse the repository at this point in the history