test: add variable arguments support for Argv #12166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment Argv only supports three arguments which fulfilled my requirements when working on nodejs#9163. This commit adds support for a variable number of arguments. There is also a no-args constructor that is the equivalent to running "node -p process.version" which is hopefully alright as a default. Refs: nodejs#9163
Trott
added
the
c++
jasnell
approved these changes
Apr 3, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 4, 2017
At the moment Argv only supports three arguments which fulfilled my requirements when working on #9163. This commit adds support for a variable number of arguments. There is also a no-args constructor that is the equivalent to running "node -p process.version" which is hopefully alright as a default. PR-URL: #12166 Ref: #9163 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 5ccaba4 |
|
cc @danbev |
|
@italoacasas Sorry I missed this message. Would you like me to open at PR against v7.x-staging with a backport? |
3 tasks
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment Argv only supports three arguments which fulfilled my
requirements when working on #9163.
This commit adds support for a variable number of arguments. There is
also a no-args constructor that is the equivalent to running "node -p
process.version" which is hopefully alright as a default.
Refs: #9163
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test