test: remove disabled debugger test #12199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current debugger is slated for removal soon. The debugger test that has been disabled for over four years is unlikely to be repaired at this point. Remove the test and its associated fixture.
|
Would it be better if we removed this when we do away with the current debugger? |
bnoordhuis
approved these changes
Apr 4, 2017
|
@thefourtheye I'd say it's long overdue for removal. It never worked reliably and it's been disabled four out of the five years it's been around. |
thefourtheye
approved these changes
Apr 4, 2017
gibfahn
approved these changes
Apr 4, 2017
cjihrig
approved these changes
Apr 4, 2017
jasnell
approved these changes
Apr 4, 2017
hiroppy
approved these changes
Apr 5, 2017
richardlau
approved these changes
Apr 5, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 6, 2017
The current debugger is slated for removal soon. The debugger test that has been disabled for over four years is unlikely to be repaired at this point. Remove the test and its associated fixture. PR-URL: #12199 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 65c100a |
|
cc @Trott |
3 tasks
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current debugger is slated for removal soon. The debugger test that
has been disabled for over four years is unlikely to be repaired at this
point. Remove the test and its associated fixture.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test debugger