Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: don't penalize setInterval/setTimeout common case #1221

Merged
merged 3 commits into from
Mar 21, 2015
Merged

lib: don't penalize setInterval/setTimeout common case #1221

merged 3 commits into from
Mar 21, 2015

Commits on Mar 20, 2015

  1. lib: don't penalize setTimeout() common case 

    The common case is where setTimeout() is called with two arguments,
the callback and the timeout.  Specifying optional arguments in the
parameter list forces common case calls to go through an arguments
adaptor stack frame.

PR-URL: nodejs#1221
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 20, 2015
    Configuration menu
    Copy the full SHA
    31da975 View commit details
    Browse the repository at this point in the history

  2. lib: don't penalize setInterval() common case 

    The common case is where setInterval() is called with two arguments,
the callback and the timeout.  Specifying optional arguments in
the parameter list forces common case calls to go through an arguments
adaptor stack frame.

PR-URL: nodejs#1221
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 20, 2015
    14 Configuration menu
    Copy the full SHA
    33fea6e View commit details
    Browse the repository at this point in the history

  3. test: add setTimeout/setInterval multi-arg tests 

    It turns out we have little to no test coverage for setTimeout() and
setInterval() calls with optional arguments.  Now we do.

PR-URL: nodejs#1221
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 20, 2015
    Configuration menu
    Copy the full SHA
    2b3b2d3 View commit details
    Browse the repository at this point in the history