vm: fix crash on fatal error in debug context #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // can't easily be taught that due to a deficiency in the V8 API: | ||
| // there is no way for the embedder to tell if the data index is | ||
| // in use. | ||
| struct ScopedEnvironment { |
There was a problem hiding this comment.
Why not just assign it? Is there any point in rolling it back?
There was a problem hiding this comment.
Two reasons:
- The environment doesn't really belong on the debug context. This is a hack to stop it from crashing until we have better ways to deal with this.
- It introduces a potential use-after-free because the pointer stays around when the non-debug context is disposed.
|
LGTM, with a small comment. |
|
LGTM, please land it ;) |
Ensure that the debug context has an Environment assigned in case a fatal error is raised. The fatal exception handler in node.cc is not equipped to deal with contexts that don't have one and can't easily be taught that due to a deficiency in the V8 API: there is no way for the embedder to tell if the data index is in use. Fixes: nodejs#1190 PR-URL: nodejs#1229 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
force-pushed
the
fix-issue-1190
branch
from
c91855e to
cf081a4
Compare
This was referenced Jul 17, 2020
This was referenced Apr 26, 2023
This was referenced Jul 8, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the debug context has an Environment assigned in case
a fatal error is raised.
The fatal exception handler in node.cc is not equipped to deal with
contexts that don't have one and can't easily be taught that due to
a deficiency in the V8 API: there is no way for the embedder to tell
if the data index is in use.
Fixes: #1190
R=@indutny?
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/356/