doc: modernize and fix code examples in path.md #12296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
hiroppy
reviewed
Apr 10, 2017
| @@ -332,7 +332,7 @@ path.normalize('/foo/bar//baz/asdf/quux/..') | |||
| On Windows: | |||
|
|
|||
| ```js | |||
| path.normalize('C:\\temp\\\\foo\\bar\\..\\'); | |||
| path.normalize('C:\\temp\\\\foo\\bar\\..\\') | |||
There was a problem hiding this comment.
Why did you delete the semicolon?
There was a problem hiding this comment.
There are sections where all semicolons are present, there are ones where all are omitted. In the most cases when examples are intended to run in REPL all the semicolon are omitted. In this section one is present and one is omitted. I've just tried to make it consistent and similar to others.
cjihrig
approved these changes
Apr 10, 2017
lpinca
approved these changes
Apr 10, 2017
jasnell
approved these changes
Apr 11, 2017
|
Landed in a912425 |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 12, 2017
Unify spaces, quotes, and semicolons. Update output examples. PR-URL: #12296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
Unify spaces, quotes, and semicolons. Update output examples. PR-URL: #12296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
Unify spaces, quotes, and semicolons. Update output examples. PR-URL: #12296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Unify spaces, quotes, and semicolons. Update output examples. PR-URL: #12296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
The docs changes are not all accurate for v6.x. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, path