-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: drop PPC BE from supported platforms #12309
Conversation
We've discussed this with the Power team within IBM and have agreement that we should drop Power Linux BE for Node version 8 as customers will be using Power Linux LE when using Node.js going forward.
cc/ @nodejs/platform-ppc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ref: nodejs/build#680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM but just thinking... do we need a proper deprecation cycle for dropping support for a platform? Does that even make sense?
@jasnell in general I think the more warning we can give people the better. This may be a bit of a special situation where Power Linux essentially switched the primary endianess and there were both options for a transition period. I suggest we land this but then discuss in the LTS team what we want the standard process to be. We should probably also do the same in terms of OS versions. |
will plan to land unless I hear objections once the 24 hours is up. |
Sounds good |
We've discussed this with the Power team within IBM and have agreement that we should drop Power Linux BE for Node version 8 as customers will be using Power Linux LE when using Node.js going forward. PR-URL: #12309 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Jaideep Bajwa <bjaideep@ca.ibm.com>
Landed in 75c471a |
For the record, this means we stopped releasing builds for ppc64 (which is big-endian) in:
|
We've discussed this with the Power team within IBM and have
agreement that we should drop Power Linux BE for Node version
8 as customers will be using Power Linux LE when using
Node.js going forward.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc