n-api: fix coverity scan report #12365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity was reporting _request.work_req as not being initialized. Add memset to ensure all of _request is initialized.
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 12, 2017
cjihrig
approved these changes
Apr 12, 2017
|
I'm thinking this is not controversial so likely does not need the 48hours waiting period |
jasnell
approved these changes
Apr 13, 2017
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Apr 14, 2017
Coverity was reporting _request.work_req as not being initialized. Add memset to ensure all of _request is initialized. PR-URL: nodejs#12365 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 46f2026 |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Coverity was reporting _request.work_req as not being initialized. Add memset to ensure all of _request is initialized. PR-URL: nodejs#12365 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity was reporting _request.work_req as not being initialized.
Add memset to ensure all of _request is initialized.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api