Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick 79aee39 from upstream v8 #12412

Merged
merged 1 commit into from
Apr 19, 2017

Commits on Apr 19, 2017

  1. deps: cherry-pick 79aee39 from upstream v8

    This is a chery-pick if you consider reducing the context to -C2
    a cherry-pick; WordIsSmi has been renamed to TaggedIsSmi upstream.
    
    Original commit message:
    
        [builtins] Fix pointer comparison in ToString builtin.
    
        This fixes the bogus {Word32Equal} comparison in the ToString
        builtin implementing Object.prototype.toString to be a pointer-size
        {WordEqual} comparison instead. Comparing just the lower half-word
        is insufficient on 64-bit architectures.
    
        R=jgruber@chromium.org
        TEST=mjsunit/regress/regress-crbug-664506
        BUG=chromium:664506
    
        Review-Url: https://codereview.chromium.org/2496043003
        Cr-Commit-Position: refs/heads/master@{nodejs#40963}
    
    Fixes: nodejs#12411
    PR-URL: nodejs#12412
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    bnoordhuis committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    f882f47 View commit details
    Browse the repository at this point in the history