Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: improve cli error message #12421

Closed
wants to merge 1 commit into from
Closed

benchmark: improve cli error message #12421

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Apr 15, 2017

When no matching benchmark files are found, a more sensible error is thrown now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • benchmark

@mscdex mscdex added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 15, 2017
benjamingr
benjamingr approved these changes Apr 15, 2017
View reviewed changes
benchmark/_cli.js Outdated
for (const scripts of benchmarks[category]) {
if (filter && scripts.lastIndexOf(filter) === -1) continue;

paths.push(path.join(category, scripts));
}
}

if (paths.length === 0)
throw new Error('No benchmarks found');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'd add "in the current folder", but I don't run this often enough anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be confusing IMHO. The CLI searches all of the benchmark/ subdirectories for benchmarks specified on the command line. It never searches the current working directory.

@mscdex
benchmark: improve cli error message
3ca50a7 
When no matching benchmark files are found, a more sensible error
is shown now.
@mscdex mscdex force-pushed the benchmark-improve-error-message branch from 43926b1 to 3ca50a7 Compare April 16, 2017 16:08
@mscdex
Copy link
Contributor Author

mscdex commented Apr 16, 2017

I've tweaked this a bit after I discovered there is already a benchmark count check both in run.js and _cli.js.

mscdex
mscdex commented Apr 16, 2017
View reviewed changes
benchmark/compare.js
@@ -35,7 +35,7 @@ const runs = cli.optional.runs ? parseInt(cli.optional.runs, 10) : 30;
const benchmarks = cli.benchmarks();

if (benchmarks.length === 0) {
console.error('no benchmarks found');
console.error('No benchmarks found');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the casing used in run.js.

jasnell pushed a commit that referenced this pull request Apr 17, 2017
@mscdex @jasnell
benchmark: improve cli error message
ccdcd91 
When no matching benchmark files are found, a more sensible error
is shown now.

PR-URL: #12421
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 17, 2017

Landed in ccdcd91

@jasnell jasnell closed this Apr 17, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@mscdex @evanlucas
benchmark: improve cli error message
67bbd2c 
When no matching benchmark files are found, a more sensible error
is shown now.

PR-URL: #12421
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@mscdex @evanlucas
benchmark: improve cli error message
6dbe58b 
When no matching benchmark files are found, a more sensible error
is shown now.

PR-URL: #12421
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@mscdex @evanlucas
benchmark: improve cli error message
b7aeed7 
When no matching benchmark files are found, a more sensible error
is shown now.

PR-URL: #12421
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented May 16, 2017

Marking as dont-land because this depends on #7094, which is semver-major. LMK if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@aqrln aqrln aqrln approved these changes

@jseijas jseijas jseijas approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mscdex @jasnell @gibfahn @thefourtheye @benjamingr @cjihrig @joyeecheung @aqrln @jseijas