Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: remove unused declaration #12432

Closed
wants to merge 1 commit into from
Closed

zlib: remove unused declaration #12432

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Overlooked in #12366. Removing this
removes a compiler warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/zlib

Also trivial enough that I would say this doesn’t need to wait 48 hours.

@addaleax
zlib: remove unused declaration
778d891 
Overlooked in nodejs#12366. Removing this
removes a compiler warning.
@addaleax addaleax added dont-land-on-v4.x lib / src Issues and PRs related to general changes in the lib or src directory. zlib Issues and PRs related to the zlib subsystem. labels Apr 15, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem. labels Apr 15, 2017
@addaleax addaleax mentioned this pull request Apr 15, 2017
Closed
2 tasks
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/9133/

@addaleax
Copy link
Member Author

Landed in ea01cd7

@addaleax addaleax closed this Apr 16, 2017
@addaleax addaleax deleted the zlib-unused branch April 16, 2017 14:15
addaleax added a commit that referenced this pull request Apr 16, 2017
@addaleax
zlib: remove unused declaration
ea01cd7 
Overlooked in #12366. Removing this
removes a compiler warning.

PR-URL: #12432
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @bnoordhuis @benjamingr @cjihrig @richardlau @gibfahn @nodejs-github-bot