Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: port test for make_callback to n-api" #12475

Closed
wants to merge 1 commit into from
Closed

Revert "test: port test for make_callback to n-api" #12475

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 17, 2017

Sigh... I think the jet lag is setting in and I need to call it quits for the afternoon. 70b51c8 is broken on Windows.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 17, 2017
@jasnell
Copy link
Member Author

jasnell commented Apr 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7461/

jasnell added a commit that referenced this pull request Apr 17, 2017
@jasnell
Revert "test: port test for make_callback to n-api"
6c60691 
This reverts commit 70b51c8.

PR-URL: #12475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 17, 2017
Closed
1 task
@jasnell
Copy link
Member Author

jasnell commented Apr 17, 2017 •
edited by addaleax
Loading

Landed

(edit by @addaleax: in 6c60691)

@jasnell jasnell closed this Apr 17, 2017
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@jasnell
Revert "test: port test for make_callback to n-api"
4414e2b 
This reverts commit 70b51c8.

PR-URL: nodejs#12475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@jasnell @MylesBorins
Revert "test: port test for make_callback to n-api"
d9f3e0d 
This reverts commit 70b51c8.

Backport-PR-URL: #19447
PR-URL: #12475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
@baby636 baby636 mentioned this pull request Jun 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @cjihrig @gibfahn @nodejs-github-bot