Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: console.log removed from test-net-localport #12483

Closed
wants to merge 1 commit into from
Closed

test: console.log removed from test-net-localport #12483

wants to merge 1 commit into from

Conversation

fhalde
Copy link
Contributor

@fhalde fhalde commented Apr 18, 2017 •
edited
Loading

There seems to be an unecessary console log
happening in a test.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@fhalde
test: console.log removed from test-net-localport
67c931f 
There seems to be an unecessary console log
happening in a test.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 18, 2017
@DavidCai1111
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7470/

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Apr 18, 2017
hiroppy pushed a commit that referenced this pull request Apr 19, 2017
@fhalde @hiroppy
test: console.log removed from test-net-localport
3ae6702 
There seems to be an unecessary console log
happening in a test.

PR-URL: #12483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@hiroppy
Copy link
Member

hiroppy commented Apr 19, 2017

landed in 3ae6702

@hiroppy hiroppy closed this Apr 19, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@fhalde @evanlucas
test: console.log removed from test-net-localport
d18c622 
There seems to be an unecessary console log
happening in a test.

PR-URL: #12483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@fhalde @evanlucas
test: console.log removed from test-net-localport
9f5c273 
There seems to be an unecessary console log
happening in a test.

PR-URL: #12483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@fhalde @evanlucas
test: console.log removed from test-net-localport
eac0d70 
There seems to be an unecessary console log
happening in a test.

PR-URL: #12483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@fhalde @gibfahn
test: console.log removed from test-net-localport
7cfa063 
There seems to be an unecessary console log
happening in a test.

PR-URL: #12483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@fhalde @MylesBorins
test: console.log removed from test-net-localport
50bfb28 
There seems to be an unecessary console log
happening in a test.

PR-URL: #12483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@fhalde @andrew749
test: console.log removed from test-net-localport
2a17165 
There seems to be an unecessary console log
happening in a test.

PR-URL: nodejs/node#12483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@baby636 baby636 mentioned this pull request Jun 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jseijas jseijas jseijas approved these changes

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.