test: refactored context type err message to regex #12596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
Apr 22, 2017
test/parallel/test-vm-context.js
Outdated
| /^TypeError: contextifiedSandbox argument must be an object\.$/; | ||
|
|
||
| [undefined, null, 0, 0.0, ''].forEach(function(e) { | ||
|
|
There was a problem hiding this comment.
Unnecessary whitespace here and in the same place in the second section.
cjihrig
approved these changes
Apr 22, 2017
test/parallel/test-vm-context.js
Outdated
| /^TypeError: contextifiedSandbox argument must be an object\.$/; | ||
|
|
||
| [undefined, null, 0, 0.0, ''].forEach(function(e) { | ||
|
|
There was a problem hiding this comment.
Can you remove this blank line.
test/parallel/test-vm-context.js
Outdated
| /^TypeError: sandbox argument must have been converted to a context\.$/; | ||
|
|
||
| [{}, []].forEach(function(e) { | ||
|
|
There was a problem hiding this comment.
Same comment here about the blank line.
There was a problem hiding this comment.
@cjihrig that was my original thought, but i figured I'd skip the type checking and be more direct. I still have one more PR for this file and could change it then. What do you recommend?
There was a problem hiding this comment.
Instead of two separate loops, you could do the following with nested arrays:
[[undefined, nonContextualSandboxErrorMsg], etc.].forEach()
Then, you pass the first element to runInContext, and use the second element as the expected error.
bengl
added
the
code-and-learn
jasnell
approved these changes
Apr 24, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 24, 2017
PR-URL: #12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in ef6a7cf |
|
Thanks for the contribution! 🎉 |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
PR-URL: #12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
PR-URL: #12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
PR-URL: #12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)