test: test documented napi_get_value_int32 behaviour #12633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We chose to document this in the docs as there are different possible behaviours. Adding this test to validate that all vm implementations do it the same way.
nodejs-github-bot
added
node-api
jasnell
approved these changes
Apr 24, 2017
cjihrig
approved these changes
Apr 25, 2017
|
re-run of arms tests: https://ci.nodejs.org/job/node-test-binary-arm/7603/ |
|
Arm re-run still had jenkins related issues so trying full CI: https://ci.nodejs.org/job/node-test-pull-request/7692/ |
|
Arm failures look to be infrastructure issues so not related, rest of CI was green. |
|
landed as 4241577 |
mhdawson
added a commit
that referenced
this pull request
Apr 26, 2017
We chose to document this in the docs as there are different possible behaviours. Adding this test to validate that all vm implementations do it the same way. PR-URL: #12633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
We chose to document this in the docs as there are different possible behaviours. Adding this test to validate that all vm implementations do it the same way. PR-URL: nodejs#12633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We chose to document this in the docs as there are
different possible behaviours. Adding this test to validate
that all vm implementations do it the same way.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api