src: remove GTEST_DONT_DEFINE_ASSERT_EQ in util.h

[danbev]

As indicated by the FIXME comment, this macro guard is no longer needed.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

src

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/7664/

[addaleax]

LGTM

Landed in 5bb06e8

[evanlucas]

This is landing on v7.x-staging, but causes a compilation error.

Undefined symbols for architecture x86_64:
  "node::Abort()", referenced from:
      node::inspector::InspectorSocketServer::HandshakeCallback(node::inspector::InspectorSocket*, node::inspector::inspector_handshake_event, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in inspector_socket_server.o
  "node::Assert(char const* const (*) [4])", referenced from:
      UtilTest_Malloc_Test::TestBody() in util.o
      UtilTest_Calloc_Test::TestBody() in util.o
      UtilTest_MaybeStackBuffer_Test::TestBody() in util.o
      node::MaybeStackBuffer<unsigned char, 1024ul>::SetLength(unsigned long) in util.o
      node::MaybeStackBuffer<unsigned char, 1024ul>::SetLengthAndZeroTerminate(unsigned long) in util.o
      node::MaybeStackBuffer<unsigned char, 1024ul>::AllocateSufficientStorage(unsigned long) in util.o
      node::MaybeStackBuffer<unsigned short, 1024ul>::SetLength(unsigned long) in util.o
      ...
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [/Volumes/code/forks/WORK-node/out/Release/cctest] Error 1
make[1]: *** Waiting for unfinished jobs....
rm fe2fa96b1035b05b2fe602777c9605ade7b05863.intermediate
make: *** [node] Error 2

Marking dont-land for now. Feel free to backport if it is needed. Thanks!

[addaleax]

I think this just depends on the backport in #12664

[gibfahn]

@danbev should this land on v6.x? It cherry-picks cleanly, but I'm not sure whether it needs to depend on the other commits in #12664, some of which are semver-minor or semver-major.

[MylesBorins]

ping @danbev