test: remove eslint comments #12669
Merged
test: remove eslint comments #12669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Apr 26, 2017
aqrln
approved these changes
Apr 26, 2017
evanlucas
approved these changes
Apr 26, 2017
gibfahn
approved these changes
Apr 26, 2017
jasnell
approved these changes
Apr 26, 2017
This commit refactors test-whatwg-url-tojson.js to remove ESLint comments. PR-URL: nodejs#12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: nodejs#12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Trott
reviewed
Apr 28, 2017
| assert_equals(JSON.stringify(a), "\"https://example.com/\"") | ||
| }) | ||
| /* eslint-enable */ | ||
| const a = new URL('https://example.com/'); |
There was a problem hiding this comment.
Oops, I don't think we wanted to make this change because now we can't do straight copy/paste from https://github.com/w3c/web-platform-tests/blob/02585db/url/url-tojson.html anymore. (Or is that test unlikely to ever change so this is OK? /cc @TimothyGu @joyeecheung)
There was a problem hiding this comment.
This should probably be reverted..also, the test suites are dual-licensed. I am not sure which license we are using but generally:
performance claims can only be made against unaltered tests
There was a problem hiding this comment.
We probably need to have useful comments in place for these cases then.
There was a problem hiding this comment.
@cjihrig Not sure if it's a good idea to put a link to https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#imported-tests ? (the link can change though)
Revert opened in #12743
There was a problem hiding this comment.
No real opinion on whether we should link to that or not, but we should definitely say something along the lines of do not modify. Preferably right next to the eslint disable comment.
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
This commit refactors test-whatwg-url-tojson.js to remove ESLint comments. PR-URL: #12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
This commit refactors test-whatwg-url-tojson.js to remove ESLint comments. PR-URL: #12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
This commit refactors test-whatwg-url-tojson.js to remove ESLint comments. PR-URL: #12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12669 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Adding dont-land-on label, let me know if it should be landed. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors two tests to remove the need for ESLint comments.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test