url: update url module to use module.exports = {} pattern #12717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
url
watilde
approved these changes
Apr 28, 2017
benjamingr
approved these changes
Apr 29, 2017
lib/url.js
Outdated
|
|
||
| exports.Url = Url; | ||
| // Legacy url.parse() API |
There was a problem hiding this comment.
Given we don't have an alternative for relative URLs yet, I'm not sure we should call it legacy in the source since there are use cases whatwg-url doesn't cover.
There was a problem hiding this comment.
Legacy definition is "denoting software or hardware that has been superseded but is difficult to replace because of its wide use." ... that would seem perfectly suitable for the url.parse() API. Legacy does not imply that the use cases have been completely handled.
There was a problem hiding this comment.
Removed the word legacy from this PR to keep that from holding up landing this.
jasnell
added a commit
that referenced
this pull request
Apr 29, 2017
PR-URL: #12717 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com
jasnell
added a commit
that referenced
this pull request
Apr 29, 2017
PR-URL: #12717 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor restructuring to
lib/url.jsto use the more efficientmodule.exports = {}pattern.Also restructure binding imports in
lib/internal/url.jsto simplify code.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url