Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing option to node PrintHelp #12763

Closed
wants to merge 1 commit into from
Closed

add missing option to node PrintHelp #12763

wants to merge 1 commit into from

Conversation

krydos
Copy link
Contributor

@krydos krydos commented Apr 30, 2017

Hi,
the --pending-deprecation option was missed from PrintHelp output of node. The option exists in doc files and of course it is handled by node itself.

P.S.
excuse me, I don't really know what core subsystem it is, so I skip it below.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 30, 2017
@addaleax
Copy link
Member

Could you update the commit message to something like node: add missing option to --help output? Otherwise this looks good, thanks. :)

@addaleax addaleax added the cli Issues and PRs related to the Node.js command line interface. label Apr 30, 2017
@krydos krydos force-pushed the node-print-help-fix branch from 28058a6 to 1ea0b01 Compare April 30, 2017 16:19
@krydos
Copy link
Contributor Author

krydos commented Apr 30, 2017

@addaleax sure, thank you for the help ;)

@krydos krydos force-pushed the node-print-help-fix branch from 1ea0b01 to 43545c3 Compare April 30, 2017 16:20
@cjihrig
Copy link
Contributor

cjihrig commented Apr 30, 2017

Does this need to be added to doc/node.1 too?

@krydos
Copy link
Contributor Author

krydos commented Apr 30, 2017

@cjihrig it is already there :)

output of the --help option is the only place I found where --pending-deprecation was missing.

cjihrig
cjihrig approved these changes Apr 30, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for double checking. LGTM

jasnell
jasnell approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thank you!

mhdawson
mhdawson approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented May 1, 2017

CI run: https://ci.nodejs.org/job/node-test-pull-request/7776/

@krydos
Copy link
Contributor Author

krydos commented May 2, 2017

CI failed :( but seems unrelated.

@addaleax
Copy link
Member

addaleax commented May 3, 2017

Landed in 896be83

@addaleax addaleax closed this May 3, 2017
addaleax pushed a commit that referenced this pull request May 3, 2017
@krydos @addaleax
node: add missing option to --help output
896be83 
PR-URL: #12763
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@krydos krydos deleted the node-print-help-fix branch May 3, 2017 13:26
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@krydos
node: add missing option to --help output
e84a7af 
PR-URL: nodejs#12763
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@krydos @addaleax @cjihrig @mhdawson @jasnell @watilde @richardlau @gibfahn @nodejs-github-bot