streams: use strict on _stream_wrap #1279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Mostly Harmless™ change to enable 'use strict' mode in _stream_wrap, bringing it in line with /all/ the other modules.
|
LGTM |
|
LGTM, if this is the last .js without strict mode ;) |
|
LGTM2 :) I will merge this. |
brendanashworth
added a commit
that referenced
this pull request
Mar 27, 2015
A Mostly Harmless™ change to enable 'use strict' mode in _stream_wrap, bringing it in line with /all/ the other modules. PR-URL: #1279 Reviewed-By: Brian White (@mscdex) <mscdex@mscdex.net> Reviewed-By: Roman Reiss (@silverwind) <me@silverwind.io> Reviewed-By: Yosuke Furukawa (@yosuke-furukawa) <yosuke.furukawa@gmail.com>
|
merged in c8fa8cc |
|
@yosuke-furukawa Not to be that guy but the commit log of c8fa8cc has overly long lines. |
|
Also the author/email on |
|
Thanks for merging, I'm away right now. |
|
ooooops, thank you for comment. I think I should get accustomed to merging process... |
|
We don't normally have github names, so it'd just be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Mostly Harmless™ change to enable 'use strict' mode in _stream_wrap,
bringing it in line with all the other modules.