doc: edit Error.captureStackTrace html comment #12962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
BridgeAR
approved these changes
May 11, 2017
lpinca
approved these changes
May 11, 2017
addaleax
requested changes
May 11, 2017
doc/api/errors.md
Outdated
| @@ -238,7 +238,7 @@ function MyError() { | |||
|
|
|||
| // Without passing MyError to captureStackTrace, the MyError | |||
| // frame would show up in the .stack property. By passing | |||
| // the constructor, we omit that frame and all frames above it. | |||
| // the constructor, we omit that frame, and retain all frames above it. | |||
There was a problem hiding this comment.
This changes the meaning of this sentence now, you would want to replace “above” with “below” if you talk about the retained frames
There was a problem hiding this comment.
@addaleax Sounds good, will update the PR. Thank you
Edit to the comment in the stack trace capture, highlighting the use of the constructorOpt argument in errors.md Ref: #12289
|
@addaleax All done. I updated the PR, replacing "above" with "below". |
cjihrig
approved these changes
May 11, 2017
jasnell
approved these changes
May 12, 2017
|
Dismissed my review. In the context of the whole text, my comment is less critical. |
|
Landed in ef71824, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
May 21, 2017
Edit to the comment in the stack trace capture, highlighting the use of the constructorOpt argument in errors.md Fixes: #12289 PR-URL: #12962 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben.bridgewater@fintura.de>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Edit to the comment in the stack trace capture, highlighting the use of the constructorOpt argument in errors.md Fixes: #12289 PR-URL: #12962 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben.bridgewater@fintura.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit to the comment in the stack trace capture, highlighting the use of
the constructorOpt argument in errors.md
Ref: #12289
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)