Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-net-GH-5504 #13025

Closed
wants to merge 1 commit into from
Closed

test: refactor test-net-GH-5504 #13025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions test/sequential/test-net-GH-5504.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@
'use strict';
const common = require('../common');

// this test only fails with CentOS 6.3 using kernel version 2.6.32
// On other linuxes and darwin, the `read` call gets an ECONNRESET in
// Ref: https://github.com/nodejs/node-v0.x-archive/issues/5504
//
// This test only fails with CentOS 6.3 using kernel version 2.6.32.
// On other Linuxes and macOS, the `read` call gets an ECONNRESET in
// that case. On sunos, the `write` call fails with EPIPE.
//
// However, old CentOS will occasionally send an EOF instead of a
// However, old CentOS will occasionally send an EOF instead of an
// ECONNRESET or EPIPE when the client has been destroyed abruptly.
//
// Make sure we don't keep trying to write or read more in that case.
Expand Down Expand Up @@ -74,25 +76,24 @@ function parent() {
NODE_DEBUG: 'net'
})
});
let c;

wrap(s.stderr, process.stderr, 'SERVER 2>');
wrap(s.stdout, process.stdout, 'SERVER 1>');
s.on('exit', common.mustCall(common.noop));
s.on('exit', common.mustCall());

s.stdout.once('data', common.mustCall(function() {
c = spawn(node, [__filename, 'client']);
const c = spawn(node, [__filename, 'client']);
wrap(c.stderr, process.stderr, 'CLIENT 2>');
wrap(c.stdout, process.stdout, 'CLIENT 1>');
c.on('exit', common.mustCall(common.noop));
c.on('exit', common.mustCall());
}));

function wrap(inp, out, w) {
inp.setEncoding('utf8');
inp.on('data', function(c) {
c = c.trim();
if (!c) return;
out.write(`${w}${c.split('\n').join(`\n${w}`)}\n`);
inp.on('data', function(chunk) {
chunk = chunk.trim();
if (!chunk) return;
out.write(`${w}${chunk.split('\n').join(`\n${w}`)}\n`);
});
}
}