doc: remove unused/duplicated reference links #13066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
May 16, 2017
doc/api/fs.md
Outdated
| @@ -2938,7 +2937,6 @@ The following constants are meant for use with the [`fs.Stats`][] object's | |||
| [`util.inspect(stats)`]: util.html#util_util_inspect_object_options | |||
| [`util.promisify()`]: util.html#util_util_promisify_original | |||
| [Caveats]: #fs_caveats | |||
| [Common System Errors]: errors.html#errors_common_system_errors | |||
There was a problem hiding this comment.
Are you sure all of these are correct? This one, for example, appears to be used.
There was a problem hiding this comment.
Oops, it was used indeed. I just updated it and re-check them all manually. Thanks!
cjihrig
approved these changes
May 17, 2017
lpinca
reviewed
May 19, 2017
| @@ -2963,7 +2963,6 @@ callback invocation, even if it has been successfully cancelled. | |||
| [`napi_create_range_error`]: #n_api_napi_create_range_error | |||
| [`napi_create_reference`]: #n_api_napi_create_reference | |||
| [`napi_create_type_error`]: #n_api_napi_create_type_error | |||
| [`napi_define_class`]: #n_api_napi_define_class | |||
| @@ -1061,7 +1061,6 @@ Returns true if input is a version 6 IP address, otherwise returns false. | |||
| [`net.Server`]: #net_class_net_server | |||
| [`net.Socket`]: #net_class_net_socket | |||
| [`net.connect()`]: #net_net_connect | |||
| [`net.connect()`]: #net_net_connect | |||
There was a problem hiding this comment.
It's also duplicated.
lpinca
approved these changes
May 20, 2017
|
landed in bfade5a. |
watilde
added a commit
that referenced
this pull request
May 20, 2017
PR-URL: #13066 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 26, 2017
Closed
3 tasks
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed some un-styled markdown at #12756, and the original PR may take more time. To avoid more conflicts and make the diff a bit small, it would be nice if we can take the docs fix commits from it. Then I removed the unused/duplicated reference links.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc