-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor event-emitter-check-listener-leaks #13164
Conversation
* add block-scoping * use common.mustCall() on callbacks that should not execute
Since github does such a bad job of comparing this, here's an export from BeyondCompare4: |
@refack GitHub provides a much more usable diff if you pass (And if you already knew that, consider it a notification for other readers who might be unaware.) |
😲 |
Landed in 16357f2 |
* add block-scoping * use common.mustCall() on callbacks that should not execute PR-URL: nodejs#13164 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* add block-scoping * use common.mustCall() on callbacks that should not execute PR-URL: #13164 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test events