Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: clean up event listener in onNewListener #13266

Closed
wants to merge 3 commits into from
Closed

readline: clean up event listener in onNewListener #13266

wants to merge 3 commits into from

Commits on May 28, 2017

  1. readline: clean up event listener in onNewListener 

    Once the Readline interface is closed, the 'data' event listener should
be removed.

Refs: nodejs#9447 (comment)
    @gibfahn
    gibfahn committed May 28, 2017
    Configuration menu
    Copy the full SHA
    6d27376 View commit details
    Browse the repository at this point in the history

  2. squash! add handler for event listener

    @gibfahn
    gibfahn committed May 28, 2017
    Configuration menu
    Copy the full SHA
    eb7ea78 View commit details
    Browse the repository at this point in the history

  3. squash! modify test to handle change

    @gibfahn
    gibfahn committed May 28, 2017
    Configuration menu
    Copy the full SHA
    ff47f20 View commit details
    Browse the repository at this point in the history