Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typos in n-api.md #13323

Closed
wants to merge 1 commit into from
Closed

doc: fix typos in n-api.md #13323

wants to merge 1 commit into from

Conversation

disjukr
Copy link
Contributor

@disjukr disjukr commented May 31, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

I think this is just typo

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels May 31, 2017
@lpinca
Copy link
Member

lpinca commented May 31, 2017

I think this doesn't need to wait the full 48 hours.

@vsemozhetbyt
Copy link
Contributor

Landed in fd54b10

Thank you, @disjukr!

vsemozhetbyt pushed a commit that referenced this pull request May 31, 2017
@disjukr @vsemozhetbyt
doc: fix typo in n-api.md
fd54b10 
PR-URL: #13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@disjukr disjukr deleted the doc-types branch May 31, 2017 07:42
jasnell pushed a commit that referenced this pull request Jun 5, 2017
@disjukr @jasnell
doc: fix typo in n-api.md
243643e 
PR-URL: #13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@disjukr
doc: fix typo in n-api.md
897bac2 
PR-URL: nodejs#13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@disjukr @MylesBorins
doc: fix typo in n-api.md
17fe21e 
Backport-PR-URL: #19447
PR-URL: #13323
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@disjukr @lpinca @vsemozhetbyt @gibfahn @nodejs-github-bot