test: check inspector support in test/inspector #13324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring node --without-ssl or --without-inspector these test will fail. The underlying issue will be: Inspector support is not available with this Node.js build /work/nodejs/node/out/Release/node: bad option: --inspect=0 This commit adds checks to see if inspector support is enabled and if not skips these tests.
nodejs-github-bot
added
dont-land-on-v4.x
inspector
test/osx failure looks unrelatednot ok 1478 sequential/test-fs-watch
---
duration_ms: 60.122
severity: fail
stack: |-
timeout
... |
gibfahn
approved these changes
May 31, 2017
cjihrig
approved these changes
May 31, 2017
eugeneo
approved these changes
May 31, 2017
sam-github
approved these changes
May 31, 2017
jasnell
approved these changes
Jun 1, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Jun 2, 2017
When configuring node --without-ssl or --without-inspector these test will fail. The underlying issue will be: Inspector support is not available with this Node.js build /work/nodejs/node/out/Release/node: bad option: --inspect=0 This commit adds checks to see if inspector support is enabled and if not skips these tests. PR-URL: nodejs#13324 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 7dfeb36 |
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
When configuring node --without-ssl or --without-inspector these test will fail. The underlying issue will be: Inspector support is not available with this Node.js build /work/nodejs/node/out/Release/node: bad option: --inspect=0 This commit adds checks to see if inspector support is enabled and if not skips these tests. PR-URL: #13324 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring node --without-ssl or --without-inspector these test
will fail. The underlying issue will be:
This commit adds checks to see if inspector support is enabled and if
not skips these tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test