-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note to tty.WriteStream event 'resize' on Windows #13576
Changes from 7 commits
6da59fe
a45bd1d
84db75d
63fa375
86dfd24
192a56f
784055f
05ce78a
5944bf0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,6 +88,17 @@ process.stdout.on('resize', () => { | |
}); | ||
``` | ||
|
||
*Note:* On Windows resize events will be emitted only if stdin is unpaused | ||
(by a call to `\resume()` or by adding a data listener) and in raw mode. It can | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove backslash please |
||
also be triggered if a terminal control sequence that moves the cursor is written | ||
to the screen. | ||
|
||
*Note:* On Windows when changing console height the resize event will be | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Can you paste the body of text you'd like? Or be very verbose about what should be replaced. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
signaled only if the console screen buffer height was also changed. For example | ||
shrinking the console window height will not cause the resize event to be | ||
emitted. Increasing the console window height will only be registered when the | ||
new console window height is greater than the current console buffer size. | ||
|
||
### writeStream.columns | ||
<!-- YAML | ||
added: v0.7.7 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit:
*Note:*
->*Note*:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...I copied this mistake from async_notes.md Should that be fixed in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
Ref: #13133