benchmark: don't check wrk when testing non-http benchmark #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,7 +120,7 @@ Benchmark.prototype.http = function(p, args, cb) { | |||
|
|
|||
| if (code) { | |||
| console.error('wrk failed with ' + code); | |||
| process.exit(code) | |||
| process.exit(code); | |||
There was a problem hiding this comment.
hmm, not sure if we care about style here or not but I'd revert this
|
LGTM otherwise |
|
Also, @JacksonTian I'm assuming it may be intentional, but the email you use with git isn't registered to you on github, so the commits don't show up under your user. :) |
|
it doesn't matter. That my company email. 发自我的 iPhone
|
when testing non-http benchmark, no need the wrk tool. so move the wrk check into http method.
bnoordhuis
pushed a commit
that referenced
this pull request
Apr 9, 2015
When running a non-http benchmark, there is no need the check for the wrk tool so move the wrk check into the http method. PR-URL: #1368 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Cheers @JacksonTian, landed in d2b62a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when testing non-http benchmark, no need the wrk tool.
so move the wrk check into http method.