Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: make REPLServer.bufferedCommand private #13687

Closed
wants to merge 4 commits into from
Closed

repl: make REPLServer.bufferedCommand private #13687

wants to merge 4 commits into from

Commits on Jul 28, 2017

  1. repl: make REPLServer.bufferedCommand private 

    Relates to #12686

The `REPLServer.bufferedCommand` property was undocumented, except
for its usage appearing, unexplained, in an example for
`REPLServer.defineCommand`. This commit deprecates that property,
privatizes it, and adds a `REPLServer.clearBufferedCommand()`
function that will clear the buffer.
    @lance
    lance committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    30e4cce View commit details
    Browse the repository at this point in the history

  2. repl: addresses PR comments 

    Change to kBufferedCommandSymbol instead of BUFFERED_COMMAND. Made
`clearBufferedCommand` exist on `REPLServer.prototype`. Minor typo
corrections.
    @lance
    lance committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    85ca3f6 View commit details
    Browse the repository at this point in the history

  3. add REPLServer.bufferedCommand deprecation code 

    and make REPLServer.bufferedCommand enumerable
    @lance
    lance committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    55a7a64 View commit details
    Browse the repository at this point in the history

  4. doc: REPLServer.bufferedCommand deprecation

    @lance
    lance committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    714bcd4 View commit details
    Browse the repository at this point in the history