Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in changelog #13713

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

not-an-aardvark
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 16, 2017
@mscdex
Copy link
Contributor

mscdex commented Jun 16, 2017

I seem to recall this being an issue before with a recent release... I wonder if there is a bug in the tool that makes the changes to the changelog or if this is just the result of manual copying and pasting?

@not-an-aardvark
Copy link
Contributor Author

Looking at the history of typo fixes in the changelog, I found b837bd2 and e44eb0e in the last year.

PR-URL: nodejs#13713
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@not-an-aardvark not-an-aardvark merged commit 9f9e3c0 into nodejs:master Jun 16, 2017
@not-an-aardvark
Copy link
Contributor Author

Landed in 9f9e3c0

@not-an-aardvark not-an-aardvark deleted the fix-changelog-typo branch June 16, 2017 07:12
addaleax pushed a commit that referenced this pull request Jun 17, 2017
PR-URL: #13713
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@addaleax addaleax mentioned this pull request Jun 17, 2017
addaleax pushed a commit that referenced this pull request Jun 21, 2017
PR-URL: #13713
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants