Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #1372

Closed
wants to merge 0 commits into from
Closed

doc: update AUTHORS list #1372

wants to merge 0 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 8, 2015

Update AUTHORS list using tools/update-authors.sh

Kohei TAKATA <kt.koheitakata@gmail.com>
Giovanny Andres Gongora Granada <gioyik@gmail.com>
Jeffrey Jagoda <jeffrey.jagoda@gmail.com>
Kelsey <ifoundthemeaningoflife@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we know Kelsey's surname?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, Breseman, @Frijol: your git user.name is just "Kelsey", do you want us to update it on our end to be "Kelsey Breseman" so it shows that way in the AUTHORS doc and commit log?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had seen it also, but due to a lack of response I had decided to just leave it as-is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! I should get around to fixing this..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in .mailmap so it's now showing up with your full name @Frijol, but you should still: git config --add user.name 'Kelsey Breseman'

@bnoordhuis
Copy link
Member

LGTM

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Apr 8, 2015
rvagg added a commit that referenced this pull request Apr 9, 2015
Update AUTHORS list using tools/update-authors.sh

PR-URL: #1372
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg closed this Apr 9, 2015
@rvagg
Copy link
Member Author

rvagg commented Apr 9, 2015

merged @ 48facf9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants