Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: clean up config_fips.gypi #13837

Closed
wants to merge 2 commits into from
Closed

build: clean up config_fips.gypi #13837

wants to merge 2 commits into from

Commits on Jun 21, 2017

  1. build: clean up config_fips.gypi 

    Currently when configuring the project using --openssl-fips a gyp
include file name config_fips.gypi will be created. If the project is
later configured but without the --openssl-fips flag an error will
occur. For example:

  $ ./configure --openssl-fips=bogus
  $ ./configure && make -j8
  ...
  /node/deps/openssl/fips/fipsld:
  line 8: /bin/fipsld: No such file or directory
  Error 127

This commit suggests removing the generate config_fips.gypi when the
--openssl-fips flag is not give on the command line.
    @danbev
    danbev committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    24f9419 View commit details
    Browse the repository at this point in the history

  2. add try/except clause incase file does not exist

    @danbev
    danbev committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    a5d7672 View commit details
    Browse the repository at this point in the history