Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check uv_ip4_addr return value #13878

Closed
wants to merge 1 commit into from
Closed

test: check uv_ip4_addr return value #13878

wants to merge 1 commit into from

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jun 22, 2017

Fixes Coverity errors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test: 2 asserts to C++ tests

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Jun 22, 2017
@mscdex mscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 22, 2017
int err = uv_tcp_connect(&connect_, &socket_,
int err = uv_ip4_addr(host.c_str(), port, &addr);
ASSERT_EQ(0, err);
err = uv_tcp_connect(&connect_, &socket_,
reinterpret_cast<const sockaddr*>(&addr),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation on the following lines needs to be adjusted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixed that.

Fixes Coverity errors.
@eugeneo
Copy link
Contributor Author

eugeneo commented Jun 26, 2017

@eugeneo
Copy link
Contributor Author

eugeneo commented Jun 26, 2017

Landed as 5fbbd25

@eugeneo eugeneo closed this Jun 26, 2017
addaleax pushed a commit that referenced this pull request Jun 29, 2017
Fixes Coverity errors.

PR-URL: #13878
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@addaleax addaleax mentioned this pull request Jun 29, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
Fixes Coverity errors.

PR-URL: #13878
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Fixes Coverity errors.

PR-URL: #13878
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants