test: check uv_ip4_addr return value #13878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
inspector
mscdex
added
the
c++
cjihrig
approved these changes
Jun 22, 2017
| int err = uv_tcp_connect(&connect_, &socket_, | ||
| int err = uv_ip4_addr(host.c_str(), port, &addr); | ||
| ASSERT_EQ(0, err); | ||
| err = uv_tcp_connect(&connect_, &socket_, | ||
| reinterpret_cast<const sockaddr*>(&addr), |
There was a problem hiding this comment.
The indentation on the following lines needs to be adjusted.
Fixes Coverity errors.
bnoordhuis
approved these changes
Jun 22, 2017
|
Landed as 5fbbd25 |
addaleax
pushed a commit
that referenced
this pull request
Jun 29, 2017
Fixes Coverity errors. PR-URL: #13878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Fixes Coverity errors. PR-URL: #13878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Fixes Coverity errors. PR-URL: #13878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Coverity errors.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test: 2 asserts to C++ tests