src: --abort-on-uncaught-exception in NODE_OPTIONS #13932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Jun 26, 2017
|
Should it be added to |
jasnell
approved these changes
Jun 26, 2017
richardlau
reviewed
Jun 27, 2017
src/node.cc
Outdated
| @@ -3746,6 +3746,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env, | |||
| "--throw-deprecation", | |||
| "--no-warnings", | |||
| "--napi-modules", | |||
| "--abort-on-uncaught-exception", | |||
There was a problem hiding this comment.
V8 options can use both - and _ (https://nodejs.org/api/cli.html#cli_v8_options), so we should cover the variants (same for --max_old_space_size).
richardlau
reviewed
Jun 27, 2017
doc/api/cli.md
Outdated
| @@ -431,6 +431,7 @@ an error if an option that is not allowed in the environment is used, such as | |||
| `-p` or a script file. | |||
|
|
|||
| Node options that are allowed are: | |||
| - `--abort-on-uncaught-exception` | |||
There was a problem hiding this comment.
Shouldn't this be listed as a V8 option like --max_old_space_size?
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to enable for post-mortem debugging. PR-URL: nodejs#13932 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sam-github
force-pushed
the
allow-abort-on-uncaught-exception-in-node-options
branch
from
bffc98b
to
c45df83
Compare
4 tasks
4 tasks
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to enable for post-mortem debugging. PR-URL: #13932 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to enable for post-mortem debugging. PR-URL: #13932 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to enable for post-mortem debugging. PR-URL: #13932 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Should this have been |
sam-github
added
the
semver-minor
|
@MylesBorins yes, I just labelled it so |
|
Also, note that all the NODE_OPTIONS changes, including this one, are collected into a semver-minor backport PR: https://github.com/nodejs/node/pull/12677/commits |
sam-github
added a commit
to sam-github/node
that referenced
this pull request
Oct 11, 2017
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to enable for post-mortem debugging. PR-URL: nodejs#13932 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
MylesBorins
added a commit
that referenced
this pull request
Nov 6, 2017
Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263
MylesBorins
added a commit
that referenced
this pull request
Nov 7, 2017
Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)