Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve the test common documentation #14148

Closed
wants to merge 2 commits into from
Closed

test: improve the test common documentation #14148

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Jul 9, 2017

For better readability and less duplication (in case a link would ever change).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 9, 2017
vsemozhetbyt
vsemozhetbyt reviewed Jul 9, 2017
View reviewed changes
test/common/README.md Outdated
[internationalization]: https://github.com/nodejs/node/wiki/Intl
[<Array>]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Jul 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: if we use an ASCII sorting for references, should not the [<...] ones precede the [internationalization]?

@refack refack self-assigned this Jul 9, 2017
@refack
Copy link
Contributor

refack commented Jul 9, 2017

/cc @nodejs/documentation @nodejs/testing

@vsemozhetbyt vsemozhetbyt added the doc Issues and PRs related to the documentations. label Jul 9, 2017
@BridgeAR
Copy link
Member Author

BridgeAR commented Jul 10, 2017 •
edited
Loading

Comment addressed

@TimothyGu
Copy link
Member

Landed in 5ffb5b6.

TimothyGu pushed a commit that referenced this pull request Jul 13, 2017
@BridgeAR @TimothyGu
test: improve the test common documentation
5ffb5b6 
PR-URL: #14148
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@jasnell jasnell closed this Jul 14, 2017
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 24, 2017
@BridgeAR @addaleax
test: improve the test common documentation
770c7c7 
PR-URL: nodejs#14148
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@addaleax addaleax mentioned this pull request Jul 24, 2017
Closed
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@refack refack removed their assignment Oct 12, 2018
@BridgeAR BridgeAR deleted the common-docu branch April 1, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.