test: improve fs.exists coverage #14301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding a test case using a path with illegal protocol
benjamingr
approved these changes
Jul 16, 2017
cjihrig
approved these changes
Jul 16, 2017
gibfahn
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
BridgeAR
approved these changes
Jul 16, 2017
|
CI was green but I canceled some of the slower ARM device tests to help clear out our current CI backlog issue. IMO, CI can be considered green for this change. |
gireeshpunathil
approved these changes
Jul 17, 2017
jasnell
approved these changes
Jul 17, 2017
tniessen
pushed a commit
that referenced
this pull request
Jul 21, 2017
By adding a test case using a path with illegal protocol PR-URL: #14301 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Landed in 201e756, thank you! CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7473/ |
addaleax
pushed a commit
that referenced
this pull request
Jul 22, 2017
By adding a test case using a path with illegal protocol PR-URL: #14301 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 24, 2017
By adding a test case using a path with illegal protocol PR-URL: #14301 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a test case using a path with illegal protocol
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
JSConf CN Code & Learn, my "next step".😁