Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace string concatenation in async-hooks/test-tlswrap.js with template literals #14319

Closed
wants to merge 3 commits into from
Closed

test: replace string concatenation in async-hooks/test-tlswrap.js with template literals #14319

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d8489d
Replace string concatenation in with template literals
vincentcn Jul 17, 2017
707e50a
update tests in async-hooks/test-tlswrap.js to just path.join istead …
vincentcn Jul 17, 2017
8a08a43
re-order the imports of buildin modules in alphabetical order
vincentcn Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/async-hooks/test-tlswrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const path = require('path');
Copy link
Member

@Trott Trott Jul 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nit pick, but can you move path below assert? In tests, we try to (but admittedly often don't) keep the built-in modules in alphabetical order. (Well, ASCII order actually. https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#lines-7-8)

const assert = require('assert');
const tick = require('./tick');
const initHooks = require('./init-hooks');
Expand All @@ -19,8 +20,8 @@ hooks.enable();
//
const server = tls
.createServer({
cert: fs.readFileSync(common.fixturesDir + '/test_cert.pem'),
key: fs.readFileSync(common.fixturesDir + '/test_key.pem')
cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem')),
key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem'))
})
.on('listening', common.mustCall(onlistening))
.on('secureConnection', common.mustCall(onsecureConnection))
Expand Down