Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x backport] tools: apply stricter indentation rules to tools #14360

Closed
wants to merge 4 commits into from
Closed

[v6.x backport] tools: apply stricter indentation rules to tools #14360

wants to merge 4 commits into from

Commits on Jul 19, 2017

  1. tools: remove no-useless-regex-char-class-escape 

    The `no-useless-regex-char-class-escape` custom lint rule was introduced
as a less aggressive alternative to some enhancements that were
introduced into ESLint. Those enhancements were blocking us from
updating ESLint. However, they have since been relaxed and the custom
rule is no longer needed. Remove it.

PR-URL: nodejs#10561
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @Trott
    Trott committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    13308b2 View commit details
    Browse the repository at this point in the history

  2. tools: fix indentation in required-modules.js 

    In preparation for applying the more strict indentation linting
available in ESLint 4.0.0, correct minor indentation issues in
tools/eslint-rules/required-modules.js.

This is the only file with indentation that does not conform to the
stricter checks.

PR-URL: nodejs#13758
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @Trott
    Trott committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    8ab455e View commit details
    Browse the repository at this point in the history

  3. tools: apply stricter indentation rules to tools 

    ESLint 4.0.0 provides stricter (and more granular) indentation checking
than previous versions. Apply the stricter indentation rules to the
tools directory.

PR-URL: nodejs#13758
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @Trott
    Trott committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    1ebad50 View commit details
    Browse the repository at this point in the history

  4. tools: fix error in custom ESLint rule 

    Fix previously-unnoticed typo in `required-modules.js`.

Refs: nodejs#13758 (comment)
PR-URL: nodejs#13758
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @Trott
    Trott committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    1088e81 View commit details
    Browse the repository at this point in the history