http: check for handle before running asyncReset() #14419
Merged
+61
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
async_hooks
cjihrig
approved these changes
Jul 22, 2017
jasnell
approved these changes
Jul 22, 2017
refack
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
I don't know the http module well enough to comment on this. I trust @refack's opinion.
😳 Just so you stop trusting me, I wanted to add this back in #13839 (comment) but forgot to open a new PR. |
refack
reviewed
Jul 22, 2017
| const agent = new http.Agent({ | ||
| keepAlive: true, | ||
| }); | ||
| const socket = new net.Socket(); |
There was a problem hiding this comment.
@trevnorris Re your comment #13045 (comment)
Could you add a test case for a Socket with a fake _handle?
|
@refack Added test. |
refack
approved these changes
Jul 24, 2017
Closed
If an uninitialized or user supplied Socket is in the freeSockets list of the Agent it would automatically attempt to run ._handle.asyncReset(), but would throw from those not existing. Guard against that by first checking that they exist. PR-URL: nodejs#14419 Fixes: nodejs#13539 Refs: nodejs#13352 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
@refack Thanks for landing this. |
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
If an uninitialized or user supplied Socket is in the freeSockets list of the Agent it would automatically attempt to run ._handle.asyncReset(), but would throw from those not existing. Guard against that by first checking that they exist. PR-URL: #14419 Fixes: #13539 Refs: #13352 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
added
baking-for-lts
MylesBorins
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http
If an uninitialized or user supplied Socket is in the freeSockets list of
the Agent it would automatically attempt to run ._handle.asyncReset(),
but would throw from those not existing. Guard against that by first
checking that they exist.
Fixes: #13539
Refs: #13352
CI: https://ci.nodejs.org/job/node-test-commit/11301/
refack: added ref to 13352