Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test-fs-read-buffer-to-string-fail as pass and flaky to all… #14472

Closed
wants to merge 2 commits into from
Closed

test: add test-fs-read-buffer-to-string-fail as pass and flaky to all… #14472

wants to merge 2 commits into from

Conversation

Jeyanthinath
Copy link
Contributor

@Jeyanthinath Jeyanthinath commented Jul 25, 2017 •
edited
Loading

Fixes #14430 [v6.x] test: investigate test-fs-read-buffer-tostring-fail

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Jul 25, 2017
@Jeyanthinath Jeyanthinath mentioned this pull request Jul 25, 2017
Closed
@refack
Copy link
Contributor

refack commented Jul 25, 2017

Quick test: https://ci.nodejs.org/job/node-test-commit-linuxone/7553/

Trott
Trott requested changes Jul 25, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an unrelated @jasnell commit in here?

@refack
Copy link
Contributor

refack commented Jul 25, 2017

Looks like there's an unrelated @jasnell commit in here?

Is it possible someone force pushed to v6.x-staging?

@refack
Copy link
Contributor

refack commented Jul 25, 2017

@sam-github was it intentional?
image

@sam-github
Copy link
Contributor

@refack Yes: #14418 (comment)

@refack
Copy link
Contributor

refack commented Jul 25, 2017

@refack Yes: #14418 (comment)

Ok.
@Jeyanthinath you'll need to rebase this PR (that will take out the extra commit)

@Jeyanthinath
Copy link
Contributor Author

@refack Sure

jasnell and others added 2 commits July 26, 2017 11:55
@jasnell @Jeyanthinath
process: add --redirect-warnings command line argument
d2e7a1e 
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

Backport-PR-URL: nodejs#14418
PR-URL: nodejs#10116
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@Jeyanthinath
test: add test-fs-read-buffer-to-string-fail as pass and flaky to all…
3726641 
… platforms
@Jeyanthinath
Copy link
Contributor Author

Jeyanthinath commented Jul 26, 2017 •
edited
Loading

Sorry Guys I have a hard time rebasing , I will repoen a new pull request

@Jeyanthinath Jeyanthinath deleted the jeyanthi#14430 branch July 26, 2017 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott requested changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jeyanthinath @refack @sam-github @jasnell @Trott @nodejs-github-bot