Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] repl: improve require() autocompletion #14525

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] repl: improve require() autocompletion #14525

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Backport of @aqrln's PR #14409 to v8.x.

@aqrln @tniessen
repl: improve require() autocompletion
2f6f4ec 
Currently REPL supports autocompletion for core modules and those found
in node_modules.  This commit adds tab completion for modules relative
to the current directory.

PR-URL: nodejs#14409
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen tniessen added the v8.x label Jul 27, 2017
@tniessen tniessen requested review from addaleax and aqrln July 27, 2017 23:35
@nodejs-github-bot nodejs-github-bot added repl Issues and PRs related to the REPL subsystem. v8.x labels Jul 27, 2017
@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9384/

@addaleax addaleax self-assigned this Jul 28, 2017
@addaleax
Copy link
Member

Landed in 5a8862b, thank you!

@addaleax addaleax closed this Jul 28, 2017
addaleax pushed a commit that referenced this pull request Jul 28, 2017
@aqrln @addaleax
repl: improve require() autocompletion
5a8862b 
Currently REPL supports autocompletion for core modules and those found
in node_modules.  This commit adds tab completion for modules relative
to the current directory.

Backport-PR-URL: #14525
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14409
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aqrln
Copy link
Contributor

aqrln commented Jul 28, 2017

Oh, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@aqrln aqrln Awaiting requested review from aqrln

Assignees

@addaleax addaleax

Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @addaleax @aqrln @nodejs-github-bot