Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x backport] path.win32 related fixes and tests #14787

Closed
wants to merge 3 commits into from

Commits on Aug 12, 2017

  1. test: increase coverage for path.parse

    PR-URL: nodejs#14438
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    tniessen authored and TimothyGu committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    5180f93 View commit details
    Browse the repository at this point in the history
  2. path: fix win32 volume-relative paths

    `path.resolve()` and `path.join()` are left alone in this commit due to
    the lack of clear semantics.
    
    PR-URL: nodejs#14440
    Fixes: nodejs#14405
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    TimothyGu committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    6fa5f35 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2017

  1. path: remove unnecessary string copies

    As the length of `path` is known at this point, there is no point in
    making an exact copy using `slice`.
    
    PR-URL: nodejs#14438
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    tniessen committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    f5a8586 View commit details
    Browse the repository at this point in the history