Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing word #14924

Closed
wants to merge 1 commit into from
Closed

doc: add missing word #14924

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Checklist

Add missing word to documentation.

Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 18, 2017
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I don’t think this PR needs to wait the customary 48 hours.

@lpinca
Copy link
Member

lpinca commented Aug 18, 2017

There is a typo in the commit message (mising).

@maclover7 maclover7 changed the title doc: add mising word doc: add missing word Aug 18, 2017
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be a better word than build to use, especially because the word recurs shortly thereafter. Perhaps binary or executable? Or maybe this?:

If you have Node.js installed already, you can build just the docs with:

All that said, I'm fine with this as it is if there's no desire to make the changes I'm suggesting here.

@maclover7
Copy link
Contributor Author

@Trott before I submitted this PR I had build as installation locally, but I wasn't sure that was the right word, since this comes after instructions for manually building Node 😞

jasnell pushed a commit that referenced this pull request Aug 18, 2017
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 18, 2017

Landed in 0914880! I see this was your first contribution! Thank you and welcome!

@jasnell jasnell closed this Aug 18, 2017
@maclover7 maclover7 deleted the jm-doc branch August 18, 2017 21:29
@Trott
Copy link
Member

Trott commented Aug 18, 2017

@Trott before I submitted this PR I had build as installation locally, but I wasn't sure that was the right word, since this comes after instructions for manually building Node 😞

It's all good. The most important thing is that the text be improved. If someone wants to come along and improve it even more later, that's great. If not, that's fine too. Thanks for taking the time to open a pull request! 🎉

MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants